Merge pull request #903 from wansir/namespace-controller

fix: return early when err is nil
2019-10-11 21:00:57 +08:00
parent 3f5cbcd4f9 78c40dc20b
commit 593304a8ce
1 changed files with 1 additions and 1 deletions
--- a/pkg/controller/namespace/namespace_controller.go
+++ b/pkg/controller/namespace/namespace_controller.go
@@ -216,8 +216,8 @@ func (r *ReconcileNamespace) checkAndCreateRoles(namespace *corev1.Namespace) er
 				err = r.Create(context.TODO(), role)
 				if err != nil {
 					klog.Error(err)
+					return err
 				}
-				return err
 			} else {
 				klog.Error(err)
 				return err