From 78c40dc20b6593c217b6537b60c01895a352dd8a Mon Sep 17 00:00:00 2001
From: hongming <talonwan@yunify.com>
Date: Fri, 11 Oct 2019 15:34:12 +0800
Subject: [PATCH] fix: return early when err is nil

Signed-off-by: hongming <talonwan@yunify.com>
---
 pkg/controller/namespace/namespace_controller.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkg/controller/namespace/namespace_controller.go b/pkg/controller/namespace/namespace_controller.go
index 6c797674b..7a8b745cb 100644
--- a/pkg/controller/namespace/namespace_controller.go
+++ b/pkg/controller/namespace/namespace_controller.go
@@ -216,8 +216,8 @@ func (r *ReconcileNamespace) checkAndCreateRoles(namespace *corev1.Namespace) er
 				err = r.Create(context.TODO(), role)
 				if err != nil {
 					klog.Error(err)
+					return err
 				}
-				return err
 			} else {
 				klog.Error(err)
 				return err