admin/kubesphere
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3121 from LinuxSuRen/fix/vet-errs

Browse Source 
Fix the errors found by go vet
This commit is contained in:
KubeSphere CI Bot
2020-11-17 18:03:33 +08:00
committed by GitHub
parent 01cc686cd3 4d19901025
commit 89de94dbf8
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/controller/storage/expansion/expansion_controller_test.go
View File

@@ -67,16 +67,16 @@ func TestSyncHandler(t *testing.T) {
}{
{
name: "mount pvc on deploy",
pvc: getFakePersistentVolumeClaim("fake-pvc", "vol-12345", "fake-sc", types.UID(123)),
pvc: getFakePersistentVolumeClaim("fake-pvc", "vol-12345", "fake-sc", types.UID(fmt.Sprintf("%d", 123))),
sc: getFakeStorageClass("fake-sc", "fake.sc.com"),
deploy: getFakeDeployment("fake-deploy", "234", 1,
getFakePersistentVolumeClaim("fake-pvc", "vol-12345", "fake-sc", types.UID(123))),
getFakePersistentVolumeClaim("fake-pvc", "vol-12345", "fake-sc", types.UID(fmt.Sprintf("%d", 123)))),
pvcKey: "default/fake-pvc",
hasError: false,
},
{
name: "unmounted pvc",
pvc: getFakePersistentVolumeClaim("fake-pvc", "vol-12345", "fake-sc", types.UID(123)),
pvc: getFakePersistentVolumeClaim("fake-pvc", "vol-12345", "fake-sc", types.UID(fmt.Sprintf("%d", 123))),
sc: getFakeStorageClass("fake-sc", "fake.sc.com"),
pvcKey: "default/fake-pvc",
hasError: true,

2
pkg/models/registries/blob.go
View File

@@ -49,7 +49,7 @@ func (r *Registry) ImageBlob(image Image, token string) (*ImageBlob, error) {
respBody, _ := GetRespBody(resp)
if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNotFound {
log.Error("got response: " + string(resp.StatusCode) + string(respBody))
log.Errorf("got response: statusCode is '%d', body is '%s'\n", resp.StatusCode, respBody)
return nil, fmt.Errorf("got image blob faild")
}

2
pkg/models/registries/manifest.go
View File

@@ -55,7 +55,7 @@ func (r *Registry) ImageManifest(image Image, token string) (*ImageManifest, err
log.Error(statusUnauthorized)
return nil, restful.NewError(resp.StatusCode, statusUnauthorized)
}
log.Error("got response: " + string(resp.StatusCode) + string(respBody))
log.Errorf("got response: statusCode is '%d', body is '%s'\n", resp.StatusCode, respBody)
return nil, restful.NewError(resp.StatusCode, "got image manifest failed")
}