Add golangci-lint workflow (#4999)

* fix lint workflow

* add golang lint

* close http response body

pkg/controller/storage/capability/capability_controller.go

@@ -154,7 +154,6 @@ func (c *StorageCapabilityController) enqueueStorageClassByCSI(csi interface{})
 			c.enqueueStorageClass(obj)
 		}
 	}
-	return
 }
 
 func (c *StorageCapabilityController) runWorker() {
@@ -246,7 +245,6 @@ func (c *StorageCapabilityController) updateSnapshotAnnotation(storageClass *sto
 	if _, err := strconv.ParseBool(storageClass.Annotations[annotationAllowSnapshot]); err != nil {
 		storageClass.Annotations[annotationAllowSnapshot] = strconv.FormatBool(snapshotAllow)
 	}
-	return
 }
 
 func (c *StorageCapabilityController) updateCloneVolumeAnnotation(storageClass *storagev1.StorageClass, cloneAllow bool) {
@@ -256,7 +254,6 @@ func (c *StorageCapabilityController) updateCloneVolumeAnnotation(storageClass *
 	if _, err := strconv.ParseBool(storageClass.Annotations[annotationAllowClone]); err != nil {
 		storageClass.Annotations[annotationAllowClone] = strconv.FormatBool(cloneAllow)
 	}
-	return
 }
 
 func (c *StorageCapabilityController) removeAnnotations(storageClass *storagev1.StorageClass) {

pkg/controller/storage/capability/capability_controller_test.go

@@ -47,7 +47,8 @@ type fixture struct {
 	snapshotSupported bool
 	// Clients
 	k8sClient *k8sfake.Clientset
-	ksClient  *ksfake.Clientset
+	//nolint:unused
+	ksClient *ksfake.Clientset
 	// Objects from here preload into NewSimpleFake.
 	storageObjects []runtime.Object // include StorageClass
 	// Objects to put in the store.

pkg/controller/storage/snapshotclass/snapshotclass_controller_test.go

@@ -45,12 +45,14 @@ var (
 )
 
 type fixture struct {
-	t                 *testing.T
+	t *testing.T
+	//nolint:unused
 	snapshotSupported bool
 	// Clients
 	k8sClient           *k8sFake.Clientset
 	snapshotClassClient *snapFake.Clientset
-	ksClient            *ksfake.Clientset
+	//nolint:unused
+	ksClient *ksfake.Clientset
 	// Objects from here preload into NewSimpleFake.
 	storageObjects       []runtime.Object // include StorageClass
 	snapshotClassObjects []runtime.Object