Add golangci-lint workflow (#4999)

* fix lint workflow

* add golang lint

* close http response body

pkg/controller/openpitrix/helmapplication/helm_application_controller.go

@@ -41,10 +41,6 @@ func init() {
 	registerMetrics()
 }
 
-const (
-	helmApplicationControllerName = "helm-application-controller"
-)
-
 var _ reconcile.Reconciler = &ReconcileHelmApplication{}
 
 // ReconcileHelmApplication reconciles a federated helm application object

pkg/controller/openpitrix/helmapplication/helm_application_controller_test.go

@@ -96,10 +96,7 @@ var _ = Describe("helmApplication", func() {
 			Eventually(func() bool {
 				var ver v1alpha1.HelmApplicationVersion
 				err := k8sClient.Get(context.Background(), types.NamespacedName{Name: appVer2.Name}, &ver)
-				if apierrors.IsNotFound(err) {
-					return true
-				}
-				return false
+				return apierrors.IsNotFound(err)
 			}, timeout, interval).Should(BeTrue())
 
 			By("Active app version exists")

pkg/controller/openpitrix/helmapplication/helm_application_version_controller.go

@@ -53,7 +53,7 @@ func (r *ReconcileHelmApplicationVersion) Reconcile(ctx context.Context, request
 	start := time.Now()
 	klog.V(4).Infof("sync helm application version: %s", request.String())
 	defer func() {
-		klog.V(4).Infof("sync helm application version end: %s, elapsed: %v", request.String(), time.Now().Sub(start))
+		klog.V(4).Infof("sync helm application version end: %s, elapsed: %v", request.String(), time.Since(start))
 	}()
 
 	appVersion := &v1alpha1.HelmApplicationVersion{}
@@ -97,10 +97,7 @@ func (r *ReconcileHelmApplicationVersion) Reconcile(ctx context.Context, request
 
 			// Delete HelmApplicationVersion
 			appVersion.ObjectMeta.Finalizers = sliceutil.RemoveString(appVersion.ObjectMeta.Finalizers, func(item string) bool {
-				if item == HelmAppVersionFinalizer {
-					return true
-				}
-				return false
+				return item == HelmAppVersionFinalizer
 			})
 			if err := r.Update(context.Background(), appVersion); err != nil {
 				return reconcile.Result{}, err