Add golangci-lint workflow (#4999)

* fix lint workflow

* add golang lint

* close http response body

pkg/controller/openpitrix/helmapplication/helm_application_controller.go

@@ -41,10 +41,6 @@ func init() {
 	registerMetrics()
 }
 
-const (
-	helmApplicationControllerName = "helm-application-controller"
-)
-
 var _ reconcile.Reconciler = &ReconcileHelmApplication{}
 
 // ReconcileHelmApplication reconciles a federated helm application object

pkg/controller/openpitrix/helmapplication/helm_application_controller_test.go

@@ -96,10 +96,7 @@ var _ = Describe("helmApplication", func() {
 			Eventually(func() bool {
 				var ver v1alpha1.HelmApplicationVersion
 				err := k8sClient.Get(context.Background(), types.NamespacedName{Name: appVer2.Name}, &ver)
-				if apierrors.IsNotFound(err) {
-					return true
-				}
-				return false
+				return apierrors.IsNotFound(err)
 			}, timeout, interval).Should(BeTrue())
 
 			By("Active app version exists")

pkg/controller/openpitrix/helmapplication/helm_application_version_controller.go

@@ -53,7 +53,7 @@ func (r *ReconcileHelmApplicationVersion) Reconcile(ctx context.Context, request
 	start := time.Now()
 	klog.V(4).Infof("sync helm application version: %s", request.String())
 	defer func() {
-		klog.V(4).Infof("sync helm application version end: %s, elapsed: %v", request.String(), time.Now().Sub(start))
+		klog.V(4).Infof("sync helm application version end: %s, elapsed: %v", request.String(), time.Since(start))
 	}()
 
 	appVersion := &v1alpha1.HelmApplicationVersion{}
@@ -97,10 +97,7 @@ func (r *ReconcileHelmApplicationVersion) Reconcile(ctx context.Context, request
 
 			// Delete HelmApplicationVersion
 			appVersion.ObjectMeta.Finalizers = sliceutil.RemoveString(appVersion.ObjectMeta.Finalizers, func(item string) bool {
-				if item == HelmAppVersionFinalizer {
-					return true
-				}
-				return false
+				return item == HelmAppVersionFinalizer
 			})
 			if err := r.Update(context.Background(), appVersion); err != nil {
 				return reconcile.Result{}, err

pkg/controller/openpitrix/helmcategory/helm_category_controller.go

@@ -25,8 +25,6 @@ import (
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
-	"k8s.io/client-go/rest"
-	"k8s.io/client-go/tools/record"
 	"k8s.io/client-go/util/workqueue"
 	"k8s.io/klog"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -178,8 +176,6 @@ var _ reconcile.Reconciler = &ReconcileHelmCategory{}
 type ReconcileHelmCategory struct {
 	client.Client
 	//Scheme   *runtime.Scheme
-	recorder record.EventRecorder
-	config   *rest.Config
 }
 
 func (r *ReconcileHelmCategory) SetupWithManager(mgr ctrl.Manager) error {
@@ -195,7 +191,7 @@ func (r *ReconcileHelmCategory) Reconcile(ctx context.Context, request reconcile
 	start := time.Now()
 	klog.V(4).Infof("sync helm category: %s", request.String())
 	defer func() {
-		klog.V(4).Infof("sync helm category end: %s, elapsed: %v", request.String(), time.Now().Sub(start))
+		klog.V(4).Infof("sync helm category end: %s, elapsed: %v", request.String(), time.Since(start))
 	}()
 
 	instance := &v1alpha1.HelmCategory{}
@@ -237,10 +233,7 @@ func (r *ReconcileHelmCategory) Reconcile(ctx context.Context, request reconcile
 			}
 
 			instance.ObjectMeta.Finalizers = sliceutil.RemoveString(instance.ObjectMeta.Finalizers, func(item string) bool {
-				if item == HelmCategoryFinalizer {
-					return true
-				}
-				return false
+				return item == HelmCategoryFinalizer
 			})
 			if err := r.Update(context.Background(), instance); err != nil {
 				return reconcile.Result{}, err
@@ -297,8 +290,7 @@ func (r *ReconcileHelmCategory) updateCategoryCount(id string) error {
 
 func (r *ReconcileHelmCategory) countApplications(id string) (int, error) {
 	list := v1alpha1.HelmApplicationList{}
-	var err error
-	err = r.List(context.TODO(), &list, client.MatchingLabels{
+	err := r.List(context.TODO(), &list, client.MatchingLabels{
 		constants.CategoryIdLabelKey:  id,
 		constants.ChartRepoIdLabelKey: v1alpha1.AppStoreRepoId,
 	})

pkg/controller/openpitrix/helmrelease/get_chart_data.go

@@ -39,7 +39,7 @@ func (r *ReconcileHelmRelease) GetChartData(rls *v1alpha1.HelmRelease) (chartNam
 			return chartName, chartData, ErrGetRepoFailed
 		}
 
-		index, err := helmrepoindex.ByteArrayToSavedIndex([]byte(repo.Status.Data))
+		index, _ := helmrepoindex.ByteArrayToSavedIndex([]byte(repo.Status.Data))
 
 		if version := index.GetApplicationVersion(rls.Spec.ApplicationId, rls.Spec.ApplicationVersionId); version != nil {
 			url := version.Spec.URLs[0]

pkg/controller/openpitrix/helmrelease/helm_release_controller.go

@@ -27,8 +27,6 @@ import (
 
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/client-go/tools/cache"
-	"k8s.io/client-go/tools/record"
 	"k8s.io/klog"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -68,10 +66,8 @@ type ReconcileHelmRelease struct {
 	StorageClient s3.Interface
 	KsFactory     externalversions.SharedInformerFactory
 	client.Client
-	recorder record.EventRecorder
 	// mock helm install && uninstall
 	helmMock                  bool
-	informer                  cache.SharedIndexInformer
 	checkReleaseStatusBackoff *flowcontrol.Backoff
 
 	clusterClients     clusterclient.ClusterClients
@@ -163,10 +159,7 @@ func (r *ReconcileHelmRelease) Reconcile(ctx context.Context, request reconcile.
 			klog.V(3).Infof("remove helm release %s finalizer", instance.Name)
 			// remove finalizer
 			instance.ObjectMeta.Finalizers = sliceutil.RemoveString(instance.ObjectMeta.Finalizers, func(item string) bool {
-				if item == HelmReleaseFinalizer {
-					return true
-				}
-				return false
+				return item == HelmReleaseFinalizer
 			})
 			if err := r.Update(context.Background(), instance); err != nil {
 				return reconcile.Result{}, err

pkg/controller/openpitrix/helmrepo/helm_repo_controller.go

@@ -102,7 +102,7 @@ func (r *ReconcileHelmRepo) Reconcile(ctx context.Context, request reconcile.Req
 	start := time.Now()
 	klog.Infof("sync repo: %s", request.Name)
 	defer func() {
-		klog.Infof("sync repo end: %s, elapsed: %v", request.Name, time.Now().Sub(start))
+		klog.Infof("sync repo end: %s, elapsed: %v", request.Name, time.Since(start))
 	}()
 	// Fetch the helmrepoes instance
 	instance := &v1alpha1.HelmRepo{}
@@ -137,10 +137,7 @@ func (r *ReconcileHelmRepo) Reconcile(ctx context.Context, request reconcile.Req
 		if sliceutil.HasString(instance.ObjectMeta.Finalizers, HelmRepoFinalizer) {
 			// remove our finalizer from the list and update it.
 			instance.ObjectMeta.Finalizers = sliceutil.RemoveString(instance.ObjectMeta.Finalizers, func(item string) bool {
-				if item == HelmRepoFinalizer {
-					return true
-				}
-				return false
+				return item == HelmRepoFinalizer
 			})
 			if err := r.Update(context.Background(), instance); err != nil {
 				return reconcile.Result{}, err