Add golangci-lint workflow (#4999)

* fix lint workflow

* add golang lint

* close http response body

pkg/controller/network/ippool/ippool_controller_test.go

@@ -48,10 +48,6 @@ func TestIPPoolSuit(t *testing.T) {
 	RunSpecs(t, "IPPool Suite")
 }
 
-var (
-	alwaysReady = func() bool { return true }
-)
-
 var _ = Describe("test ippool", func() {
 	pool := &v1alpha1.IPPool{
 		TypeMeta: v1.TypeMeta{},
@@ -138,11 +134,7 @@ var _ = Describe("test ippool", func() {
 
 		Eventually(func() bool {
 			result, _ := ksclient.NetworkV1alpha1().IPPools().Get(context.TODO(), pool.Name, v1.GetOptions{})
-			if result.Status.Allocations != 1 {
-				return false
-			}
-
-			return true
+			return result.Status.Allocations == 1
 		}, 3*time.Second).Should(Equal(true))
 	})
 
@@ -153,11 +145,7 @@ var _ = Describe("test ippool", func() {
 		ipamClient.ReleaseByHandle("testhandle")
 		Eventually(func() bool {
 			result, _ := ksclient.NetworkV1alpha1().IPPools().Get(context.TODO(), pool.Name, v1.GetOptions{})
-			if result.Status.Allocations != 0 {
-				return false
-			}
-
-			return true
+			return result.Status.Allocations == 0
 		}, 3*time.Second).Should(Equal(true))
 
 		err := ksclient.NetworkV1alpha1().IPPools().Delete(context.TODO(), pool.Name, v1.DeleteOptions{})

pkg/controller/network/nsnetworkpolicy/nsnetworkpolicy_test.go

@@ -28,7 +28,6 @@ import (
 	netv1 "k8s.io/api/networking/v1"
 	"k8s.io/apimachinery/pkg/util/yaml"
 	kubeinformers "k8s.io/client-go/informers"
-	informerv1 "k8s.io/client-go/informers/core/v1"
 	kubefake "k8s.io/client-go/kubernetes/fake"
 	"k8s.io/klog"
 
@@ -37,21 +36,15 @@ import (
 
 	ksfake "kubesphere.io/kubesphere/pkg/client/clientset/versioned/fake"
 	ksinformers "kubesphere.io/kubesphere/pkg/client/informers/externalversions"
-	nsnppolicyinformer "kubesphere.io/kubesphere/pkg/client/informers/externalversions/network/v1alpha1"
-	workspaceinformer "kubesphere.io/kubesphere/pkg/client/informers/externalversions/tenant/v1alpha1"
 	"kubesphere.io/kubesphere/pkg/constants"
 	"kubesphere.io/kubesphere/pkg/controller/network/nsnetworkpolicy/provider"
 	options "kubesphere.io/kubesphere/pkg/simple/client/network"
 )
 
 var (
-	c                 *NSNetworkPolicyController
-	stopCh            chan struct{}
-	nsnpInformer      nsnppolicyinformer.NamespaceNetworkPolicyInformer
-	serviceInformer   informerv1.ServiceInformer
-	workspaceInformer workspaceinformer.WorkspaceInformer
-	namespaceInformer informerv1.NamespaceInformer
-	alwaysReady       = func() bool { return true }
+	c           *NSNetworkPolicyController
+	stopCh      chan struct{}
+	alwaysReady = func() bool { return true }
 )
 
 const (

pkg/controller/network/nsnetworkpolicy/provider/ns_k8s.go

@@ -89,6 +89,7 @@ func (c *k8sPolicyController) run(threadiness int, reconcilerPeriod string, stop
 	// Wait until we are in sync with the Kubernetes API before starting the
 	// resource cache.
 	klog.Info("Waiting to sync with Kubernetes API (NetworkPolicy)")
+	//nolint:staticcheck
 	if ok := cache.WaitForCacheSync(stopCh, c.hasSynced); !ok {
 	}
 	klog.Infof("Finished syncing with Kubernetes API (NetworkPolicy)")