fix bugs reported by sonarqube

Signed-off-by: Roland.Ma <rolandma@kubesphere.io>
This commit is contained in:
Roland.Ma
2021-11-01 09:01:49 +00:00
parent eee3b7d1a3
commit d1adef00f6
4 changed files with 5 additions and 24 deletions

View File

@@ -242,16 +242,9 @@ func (t *tenantOperator) makeQueryOptions(user user.Info, q meteringv1alpha1.Que
return
}
if decision != authorizer.DecisionAllow {
if q.WorkspaceName != "" {
// specified by WorkspaceName & NamespaceName and not allowed
if q.NamespaceName != "" {
return qo, errors.New(fmt.Sprintf(meteringv1alpha1.ErrScopeNotAllowed, nsScope))
}
} else {
// specified by NamespaceName & NamespaceName and not allowed
if q.NamespaceName != "" {
return qo, errors.New(fmt.Sprintf(meteringv1alpha1.ErrScopeNotAllowed, nsScope))
}
// specified by WorkspaceName & NamespaceName and not allowed
if q.NamespaceName != "" {
return qo, errors.New(fmt.Sprintf(meteringv1alpha1.ErrScopeNotAllowed, nsScope))
}
if q.ResourceFilter == "" {