fix bugs reported by sonarqube

Signed-off-by: Roland.Ma <rolandma@kubesphere.io>
2021-11-01 09:01:49 +00:00
parent eee3b7d1a3
commit d1adef00f6
4 changed files with 5 additions and 24 deletions
--- a/pkg/models/openpitrix/repos.go
+++ b/pkg/models/openpitrix/repos.go
@@ -220,10 +220,6 @@ func (c *repoOperator) ModifyRepo(id string, request *ModifyRepoRequest) error {
 			if userInfo != nil {
 				cred.Password, _ = userInfo.Password()
 				cred.Username = userInfo.Username()
-			} else {
-				// trim the old credential
-				cred.Password, _ = userInfo.Password()
-				cred.Username = userInfo.Username()
 			}
 		} else if strings.HasPrefix(*request.URL, "s3://") {
 			cfg := v1alpha1.S3Config{}