From 8fbfc734d26d435dd039cec28c926b183626e1ce Mon Sep 17 00:00:00 2001 From: Yoshino Date: Tue, 3 Aug 2021 14:48:06 +0800 Subject: [PATCH 1/2] Modify function error comments:"RegisterGenericProvider" and "GetOAuthProvider" --- .../authentication/identityprovider/identity_provider.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/apiserver/authentication/identityprovider/identity_provider.go b/pkg/apiserver/authentication/identityprovider/identity_provider.go index 730b08f3b..847f169b6 100644 --- a/pkg/apiserver/authentication/identityprovider/identity_provider.go +++ b/pkg/apiserver/authentication/identityprovider/identity_provider.go @@ -87,7 +87,7 @@ func GetGenericProvider(providerName string) (GenericProvider, error) { return nil, identityProviderNotFound } -// GetGenericProvider returns OAuthProvider with given name +// GetOAuthProvider returns OAuthProvider with given name func GetOAuthProvider(providerName string) (OAuthProvider, error) { if provider, ok := oauthProviders[providerName]; ok { return provider, nil @@ -100,7 +100,7 @@ func RegisterOAuthProvider(factory OAuthProviderFactory) { oauthProviderFactories[factory.Type()] = factory } -// RegisterOAuthProvider register GenericProviderFactory with the specified type +// RegisterGenericProvider register GenericProviderFactory with the specified type func RegisterGenericProvider(factory GenericProviderFactory) { genericProviderFactories[factory.Type()] = factory } From ad6acc5fb6a68a44daf37d0a491eb9ca93468596 Mon Sep 17 00:00:00 2001 From: nanjofan <68266519+nanjofan@users.noreply.github.com> Date: Wed, 4 Aug 2021 13:48:06 +0800 Subject: [PATCH 2/2] Update pkg/apiserver/authentication/identityprovider/identity_provider.go Co-authored-by: hongming --- .../authentication/identityprovider/identity_provider.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/apiserver/authentication/identityprovider/identity_provider.go b/pkg/apiserver/authentication/identityprovider/identity_provider.go index 847f169b6..af0d77381 100644 --- a/pkg/apiserver/authentication/identityprovider/identity_provider.go +++ b/pkg/apiserver/authentication/identityprovider/identity_provider.go @@ -100,7 +100,7 @@ func RegisterOAuthProvider(factory OAuthProviderFactory) { oauthProviderFactories[factory.Type()] = factory } -// RegisterGenericProvider register GenericProviderFactory with the specified type +// RegisterGenericProvider registers GenericProviderFactory with the specified type func RegisterGenericProvider(factory GenericProviderFactory) { genericProviderFactories[factory.Type()] = factory }