Merge pull request #3651 from xyz-li/app-fix

Fix: fix app repo and helm app bugs

pkg/controller/openpitrix/helmapplication/helm_application_controller.go

@@ -87,6 +87,9 @@ func (r *ReconcileHelmApplication) Reconcile(request reconcile.Request) (reconci
 				return reconcile.Result{}, nil
 			}
 		}
+
+		// app has changed, update app status
+		return reconcile.Result{}, updateHelmApplicationStatus(r.Client, strings.TrimSuffix(app.Name, v1alpha1.HelmApplicationAppStoreSuffix), inAppStore(app))
 	} else {
 		// delete app copy in appStore
 		if !inAppStore(app) {
@@ -164,11 +167,6 @@ func (r *ReconcileHelmApplication) createAppCopyInAppStore(ctx context.Context,
 		}
 	}
 
-	if app.Status.State == "" {
-		// update status if needed
-		return updateHelmApplicationStatus(r.Client, originApp.Name, true)
-	}
-
 	return nil
 }