admin/kubesphere
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: controller error handle function

Browse Source 
Signed-off-by: hongming <talonwan@yunify.com>
This commit is contained in:
hongming
2019-09-20 20:58:19 +08:00
parent f85f6b6b58
commit a4281989c3
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/application/application_controller.go
View File

@@ -242,7 +242,7 @@ func (v *ApplicationController) enqueueObject(obj interface{}) {
} }
func (v *ApplicationController) handleErr(err error, key interface{}) { func (v *ApplicationController) handleErr(err error, key interface{}) {
if err != nil { if err == nil {
v.queue.Forget(key) v.queue.Forget(key)
return return
} }

2
pkg/controller/destinationrule/destinationrule_controller.go
View File

@@ -471,7 +471,7 @@ func (v *DestinationRuleController) addServicePolicy(obj interface{}) {
} }
func (v *DestinationRuleController) handleErr(err error, key interface{}) { func (v *DestinationRuleController) handleErr(err error, key interface{}) {
if err != nil { if err == nil {
v.queue.Forget(key) v.queue.Forget(key)
return return
} }

3
pkg/controller/job/job_controller.go
View File

@@ -170,6 +170,7 @@ func (v *JobController) syncJob(key string) error {
if err != nil { if err != nil {
log.Error(err, "make job revision failed", "namespace", namespace, "name", name) log.Error(err, "make job revision failed", "namespace", namespace, "name", name)
return err
} }
return nil return nil
@@ -186,7 +187,7 @@ func (v *JobController) addJob(obj interface{}) {
} }
func (v *JobController) handleErr(err error, key interface{}) { func (v *JobController) handleErr(err error, key interface{}) {
if err != nil { if err == nil {
v.queue.Forget(key) v.queue.Forget(key)
return return
} }

2
pkg/controller/virtualservice/virtualservice_controller.go
View File

@@ -484,7 +484,7 @@ func (v *VirtualServiceController) addStrategy(obj interface{}) {
} }
func (v *VirtualServiceController) handleErr(err error, key interface{}) { func (v *VirtualServiceController) handleErr(err error, key interface{}) {
if err != nil { if err == nil {
v.queue.Forget(key) v.queue.Forget(key)
return return
} }