fix: controller error handle function

Signed-off-by: hongming <talonwan@yunify.com>
2019-09-20 20:58:19 +08:00
parent f85f6b6b58
commit a4281989c3
4 changed files with 5 additions and 4 deletions
--- a/pkg/controller/job/job_controller.go
+++ b/pkg/controller/job/job_controller.go
@@ -170,6 +170,7 @@ func (v *JobController) syncJob(key string) error {

 	if err != nil {
 		log.Error(err, "make job revision failed", "namespace", namespace, "name", name)
+		return err
 	}

 	return nil
@@ -186,7 +187,7 @@ func (v *JobController) addJob(obj interface{}) {
 }

 func (v *JobController) handleErr(err error, key interface{}) {
-	if err != nil {
+	if err == nil {
 		v.queue.Forget(key)
 		return
 	}