From 9e235ce0dfed88665796afd69d81a428a06ef553 Mon Sep 17 00:00:00 2001 From: LiHui Date: Tue, 30 Mar 2021 17:27:11 +0800 Subject: [PATCH] Fix: update application status when it has changed Signed-off-by: LiHui --- .../helmapplication/helm_application_controller.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/controller/openpitrix/helmapplication/helm_application_controller.go b/pkg/controller/openpitrix/helmapplication/helm_application_controller.go index 6548a0b89..f1cd4d61e 100644 --- a/pkg/controller/openpitrix/helmapplication/helm_application_controller.go +++ b/pkg/controller/openpitrix/helmapplication/helm_application_controller.go @@ -87,6 +87,9 @@ func (r *ReconcileHelmApplication) Reconcile(request reconcile.Request) (reconci return reconcile.Result{}, nil } } + + // app has changed, update app status + return reconcile.Result{}, updateHelmApplicationStatus(r.Client, strings.TrimSuffix(app.Name, v1alpha1.HelmApplicationAppStoreSuffix), inAppStore(app)) } else { // delete app copy in appStore if !inAppStore(app) { @@ -164,11 +167,6 @@ func (r *ReconcileHelmApplication) createAppCopyInAppStore(ctx context.Context, } } - if app.Status.State == "" { - // update status if needed - return updateHelmApplicationStatus(r.Client, originApp.Name, true) - } - return nil }