From 981669ca5a56a7172eff86a10505d12cc6d7b0f5 Mon Sep 17 00:00:00 2001
From: hongming <talonwan@yunify.com>
Date: Fri, 8 Nov 2019 17:13:26 +0800
Subject: [PATCH] fix openpitrix resource sort param

Signed-off-by: hongming <talonwan@yunify.com>
---
 pkg/apiserver/openpitrix/applications.go | 5 +++++
 pkg/models/openpitrix/applications.go    | 2 +-
 pkg/models/openpitrix/apps.go            | 6 +++---
 pkg/models/openpitrix/categories.go      | 2 +-
 pkg/models/openpitrix/repos.go           | 2 +-
 5 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/pkg/apiserver/openpitrix/applications.go b/pkg/apiserver/openpitrix/applications.go
index 8fafc9a17..f536cf85f 100644
--- a/pkg/apiserver/openpitrix/applications.go
+++ b/pkg/apiserver/openpitrix/applications.go
@@ -42,6 +42,11 @@ func ListApplications(req *restful.Request, resp *restful.Response) {
 	orderBy := req.QueryParameter(params.OrderByParam)
 	reverse := params.ParseReverse(req)
 
+	if orderBy == "" {
+		orderBy = "create_time"
+		reverse = true
+	}
+
 	if err != nil {
 		resp.WriteHeaderAndEntity(http.StatusBadRequest, errors.Wrap(err))
 		return
diff --git a/pkg/models/openpitrix/applications.go b/pkg/models/openpitrix/applications.go
index f7a3751ab..2254f1619 100644
--- a/pkg/models/openpitrix/applications.go
+++ b/pkg/models/openpitrix/applications.go
@@ -83,7 +83,7 @@ func ListApplications(conditions *params.Conditions, limit, offset int, orderBy
 	if orderBy != "" {
 		describeClustersRequest.SortKey = &wrappers.StringValue{Value: orderBy}
 	}
-	describeClustersRequest.Reverse = &wrappers.BoolValue{Value: reverse}
+	describeClustersRequest.Reverse = &wrappers.BoolValue{Value: !reverse}
 	resp, err := client.Cluster().DescribeClusters(openpitrix.SystemContext(), describeClustersRequest)
 	if err != nil {
 		klog.Errorln(err)
diff --git a/pkg/models/openpitrix/apps.go b/pkg/models/openpitrix/apps.go
index 215dbc9eb..1ba62acfb 100644
--- a/pkg/models/openpitrix/apps.go
+++ b/pkg/models/openpitrix/apps.go
@@ -587,7 +587,7 @@ func ListAppVersionAudits(conditions *params.Conditions, orderBy string, reverse
 	if orderBy != "" {
 		describeAppVersionAudits.SortKey = &wrappers.StringValue{Value: orderBy}
 	}
-	describeAppVersionAudits.Reverse = &wrappers.BoolValue{Value: reverse}
+	describeAppVersionAudits.Reverse = &wrappers.BoolValue{Value: !reverse}
 	describeAppVersionAudits.Limit = uint32(limit)
 	describeAppVersionAudits.Offset = uint32(offset)
 	resp, err := client.App().DescribeAppVersionAudits(openpitrix.SystemContext(), describeAppVersionAudits)
@@ -626,7 +626,7 @@ func ListAppVersionReviews(conditions *params.Conditions, orderBy string, revers
 	if orderBy != "" {
 		describeAppVersionReviews.SortKey = &wrappers.StringValue{Value: orderBy}
 	}
-	describeAppVersionReviews.Reverse = &wrappers.BoolValue{Value: reverse}
+	describeAppVersionReviews.Reverse = &wrappers.BoolValue{Value: !reverse}
 	describeAppVersionReviews.Limit = uint32(limit)
 	describeAppVersionReviews.Offset = uint32(offset)
 	// TODO icon is needed
@@ -669,7 +669,7 @@ func ListAppVersions(conditions *params.Conditions, orderBy string, reverse bool
 	if orderBy != "" {
 		describeAppVersionsRequest.SortKey = &wrappers.StringValue{Value: orderBy}
 	}
-	describeAppVersionsRequest.Reverse = &wrappers.BoolValue{Value: reverse}
+	describeAppVersionsRequest.Reverse = &wrappers.BoolValue{Value: !reverse}
 	describeAppVersionsRequest.Limit = uint32(limit)
 	describeAppVersionsRequest.Offset = uint32(offset)
 	resp, err := client.App().DescribeAppVersions(openpitrix.SystemContext(), describeAppVersionsRequest)
diff --git a/pkg/models/openpitrix/categories.go b/pkg/models/openpitrix/categories.go
index f827a71a8..7215151ce 100644
--- a/pkg/models/openpitrix/categories.go
+++ b/pkg/models/openpitrix/categories.go
@@ -144,7 +144,7 @@ func ListCategories(conditions *params.Conditions, orderBy string, reverse bool,
 	if orderBy != "" {
 		req.SortKey = &wrappers.StringValue{Value: orderBy}
 	}
-	req.Reverse = &wrappers.BoolValue{Value: reverse}
+	req.Reverse = &wrappers.BoolValue{Value: !reverse}
 	req.Limit = uint32(limit)
 	req.Offset = uint32(offset)
 	resp, err := client.Category().DescribeCategories(openpitrix.SystemContext(), req)
diff --git a/pkg/models/openpitrix/repos.go b/pkg/models/openpitrix/repos.go
index 5954336d4..754cc63d0 100644
--- a/pkg/models/openpitrix/repos.go
+++ b/pkg/models/openpitrix/repos.go
@@ -190,7 +190,7 @@ func ListRepos(conditions *params.Conditions, orderBy string, reverse bool, limi
 	if orderBy != "" {
 		req.SortKey = &wrappers.StringValue{Value: orderBy}
 	}
-	req.Reverse = &wrappers.BoolValue{Value: reverse}
+	req.Reverse = &wrappers.BoolValue{Value: !reverse}
 	req.Limit = uint32(limit)
 	req.Offset = uint32(offset)
 	resp, err := client.Repo().DescribeRepos(openpitrix.SystemContext(), req)