From 81c0df01fef88224930321de9e7415191f7c72de Mon Sep 17 00:00:00 2001 From: rick Date: Fri, 22 Jan 2021 16:53:19 +0800 Subject: [PATCH] Fix the wrong XML parse of Pipeline choice parameter Signed-off-by: rick --- pkg/simple/client/devops/jenkins/pipeline_internal.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/simple/client/devops/jenkins/pipeline_internal.go b/pkg/simple/client/devops/jenkins/pipeline_internal.go index 04e3a4ea2..0052f8d02 100644 --- a/pkg/simple/client/devops/jenkins/pipeline_internal.go +++ b/pkg/simple/client/devops/jenkins/pipeline_internal.go @@ -170,11 +170,9 @@ func appendParametersToEtree(properties *etree.Element, parameters []devopsv1alp case "choice": choices := paramDefine.CreateElement("choices") choices.CreateAttr("class", "java.util.Arrays$ArrayList") - a := choices.CreateElement("a") - a.CreateAttr("class", "string-array") choiceValues := strings.Split(parameter.DefaultValue, "\n") for _, choiceValue := range choiceValues { - a.CreateElement("string").SetText(choiceValue) + choices.CreateElement("string").SetText(choiceValue) } case "file": break @@ -232,7 +230,7 @@ func getParametersfromEtree(properties *etree.Element) []devopsv1alpha3.Paramete Description: param.SelectElement("description").Text(), Type: ParameterTypeMap["hudson.model.ChoiceParameterDefinition"], } - choices := param.SelectElement("choices").SelectElement("a").SelectElements("string") + choices := param.SelectElement("choices").SelectElements("string") for _, choice := range choices { choiceParameter.DefaultValue += fmt.Sprintf("%s\n", choice.Text()) }