From 8191264bf18c097d53af7e9782f68765bdb4ccc3 Mon Sep 17 00:00:00 2001 From: Jeff Date: Tue, 26 Mar 2019 14:17:05 +0800 Subject: [PATCH] fix event format error xx --- .travis.yml | 4 ++-- pkg/controller/destinationrule/destinationrule_controller.go | 4 ++-- pkg/controller/virtualservice/virtualservice_controller.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5bb0c2a33..9f8c4c4d5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,11 +19,11 @@ before_script: - bash hack/install_kubebuilder.sh script: - - make all && bash hack/docker_build.sh + - make all deploy: skip_cleanup: true provider: script - script: bash hack/docker_push.sh + script: bash hack/docker_build.sh && bash hack/docker_push.sh on: branch: master diff --git a/pkg/controller/destinationrule/destinationrule_controller.go b/pkg/controller/destinationrule/destinationrule_controller.go index 347925fcd..c5fc6b5fb 100644 --- a/pkg/controller/destinationrule/destinationrule_controller.go +++ b/pkg/controller/destinationrule/destinationrule_controller.go @@ -277,9 +277,9 @@ func (v *DestinationRuleController) syncService(key string) error { } if createDestinationRule { - v.eventRecorder.Eventf(newDestinationRule, v1.EventTypeWarning, "FailedToCreateDestinationRule", "Failed to create destinationrule for service %v/%v: %v", service.Namespace, service.Name, err) + v.eventRecorder.Event(newDestinationRule, v1.EventTypeWarning, "FailedToCreateDestinationRule", fmt.Sprintf("Failed to create destinationrule for service %v/%v: %v", service.Namespace, service.Name, err)) } else { - v.eventRecorder.Eventf(newDestinationRule, v1.EventTypeWarning, "FailedToUpdateDestinationRule", "Failed to update destinationrule for service %v/%v: %v", service.Namespace, service.Name, err) + v.eventRecorder.Event(newDestinationRule, v1.EventTypeWarning, "FailedToUpdateDestinationRule", fmt.Sprintf("Failed to update destinationrule for service %v/%v: %v", service.Namespace, service.Name, err)) } return err diff --git a/pkg/controller/virtualservice/virtualservice_controller.go b/pkg/controller/virtualservice/virtualservice_controller.go index 6a41b8de0..5efaf020b 100644 --- a/pkg/controller/virtualservice/virtualservice_controller.go +++ b/pkg/controller/virtualservice/virtualservice_controller.go @@ -273,7 +273,7 @@ func (v *VirtualServiceController) syncService(key string) error { if len(vs.Spec.Http) > 0 || len(vs.Spec.Tcp) > 0 { _, err := v.virtualServiceClient.NetworkingV1alpha3().VirtualServices(namespace).Create(vs) if err != nil { - v.eventRecorder.Eventf(vs, v1.EventTypeWarning, "FailedToCreateVirtualService", "Failed to create virtualservice for service %v/%v: %v", service.Namespace, service.Name, err) + v.eventRecorder.Event(vs, v1.EventTypeWarning, "FailedToCreateVirtualService", fmt.Sprintf("Failed to create virtualservice for service %v/%v: %v", service.Namespace, service.Name, err)) log.Error(err, "create virtualservice for service failed.", "service", service) return err }