add built-in repo to dynamiclly load app into app-store

Signed-off-by: LiHui <andrewli@kubesphere.io>

pkg/models/openpitrix/applications.go

@@ -175,11 +175,16 @@ func (c *applicationOperator) ValidatePackage(request *ValidatePackageRequest) (
 
 func (c *applicationOperator) DoAppAction(appId string, request *ActionRequest) error {
 
-	app, err := c.appLister.Get(appId)
+	app, err := c.getHelmApplication(appId)
 	if err != nil {
 		return err
 	}
 
+	// All the app belonging to a built-in repo have a label `application.kubesphere.io/repo-id`, and the value should be `builtin-stable` or else.
+	if repoId, exist := app.Labels[constants.ChartRepoIdLabelKey]; exist && repoId != v1alpha1.AppStoreRepoId {
+		return apierrors.NewForbidden(v1alpha1.Resource(v1alpha1.ResourcePluralHelmApplication), app.Name, errors.New("application is immutable"))
+	}
+
 	var filterState string
 	switch request.Action {
 	case ActionSuspend:
@@ -393,12 +398,17 @@ func (c *applicationOperator) ModifyApp(appId string, request *ModifyAppRequest)
 		return invalidS3Config
 	}
 
-	app, err := c.appLister.Get(appId)
+	app, err := c.getHelmApplication(appId)
 	if err != nil {
 		klog.Error(err)
 		return err
 	}
 
+	// All the app belonging to a built-in repo have a label `application.kubesphere.io/repo-id`, and the value should be `builtin-stable` or else.
+	if repoId, exist := app.Labels[constants.ChartRepoIdLabelKey]; exist && repoId != v1alpha1.AppStoreRepoId {
+		return apierrors.NewForbidden(v1alpha1.Resource(v1alpha1.ResourcePluralHelmApplication), app.Name, errors.New("application is immutable"))
+	}
+
 	appCopy := app.DeepCopy()
 	// modify category
 	if request.CategoryID != nil {
@@ -602,16 +612,32 @@ func (c *applicationOperator) listApps(conditions *params.Conditions) (ret []*v1
 	repoId := conditions.Match[RepoId]
 	if repoId != "" && repoId != v1alpha1.AppStoreRepoId {
 		// get helm application from helm repo
-		if ret, exists := c.cachedRepos.ListApplicationsByRepoId(repoId); !exists {
+		if ret, exists := c.cachedRepos.ListApplicationsInRepo(repoId); !exists {
 			klog.Warningf("load repo failed, repo id: %s", repoId)
 			return nil, loadRepoInfoFailed
 		} else {
 			return ret, nil
 		}
+	} else if repoId == v1alpha1.AppStoreRepoId {
+		// List apps in the app-store and built-in repo
+		if c.backingStoreClient == nil {
+			return []*v1alpha1.HelmApplication{}, nil
+		}
+
+		ls := map[string]string{}
+		// We just care about the category label when listing apps in built-in repo.
+		if conditions.Match[CategoryId] != "" {
+			ls[constants.CategoryIdLabelKey] = conditions.Match[CategoryId]
+		}
+		appInRepo, _ := c.cachedRepos.ListApplicationsInBuiltinRepo(labels.SelectorFromSet(ls))
+
+		ret, err = c.appLister.List(labels.SelectorFromSet(buildLabelSelector(conditions)))
+		ret = append(ret, appInRepo...)
 	} else {
 		if c.backingStoreClient == nil {
 			return []*v1alpha1.HelmApplication{}, nil
 		}
+
 		ret, err = c.appLister.List(labels.SelectorFromSet(buildLabelSelector(conditions)))
 	}
 

pkg/models/openpitrix/applicationversions.go

@@ -141,7 +141,7 @@ func (c *applicationOperator) DeleteAppVersion(id string) error {
 }
 
 func (c *applicationOperator) DescribeAppVersion(id string) (*AppVersion, error) {
-	version, err := c.versionLister.Get(id)
+	version, err := c.getAppVersion(id)
 	if err != nil {
 		klog.Errorf("get app version [%s] failed, error: %s", id, err)
 		return nil, err
@@ -152,12 +152,17 @@ func (c *applicationOperator) DescribeAppVersion(id string) (*AppVersion, error)
 
 func (c *applicationOperator) ModifyAppVersion(id string, request *ModifyAppVersionRequest) error {
 
-	version, err := c.versionLister.Get(id)
+	version, err := c.getAppVersion(id)
 	if err != nil {
 		klog.Errorf("get app version [%s] failed, error: %s", id, err)
 		return err
 	}
 
+	// All the app versions belonging to a built-in repo have a label `application.kubesphere.io/repo-id`, and the value should be `builtin-stable` or else.
+	if repoId, exists := version.Labels[constants.ChartRepoIdLabelKey]; exists && repoId != v1alpha1.AppStoreRepoId {
+		return apierrors.NewForbidden(v1alpha1.Resource(v1alpha1.ResourcePluralHelmApplicationVersion), version.Name, errors.New("version is immutable"))
+	}
+
 	versionCopy := version.DeepCopy()
 	spec := &versionCopy.Spec
 
@@ -355,12 +360,17 @@ func (c *applicationOperator) DoAppVersionAction(versionId string, request *Acti
 	}
 	state := v1alpha1.StateDraft
 
-	version, err := c.versionLister.Get(versionId)
+	version, err := c.getAppVersion(versionId)
 	if err != nil {
 		klog.Errorf("get app version %s failed, error: %s", versionId, err)
 		return err
 	}
 
+	// All the app versions belonging to a built-in repo have a label `application.kubesphere.io/repo-id`, and the value should be `builtin-stable` or else.
+	if repoId, exists := version.Labels[constants.ChartRepoIdLabelKey]; exists && repoId != v1alpha1.AppStoreRepoId {
+		return apierrors.NewForbidden(v1alpha1.Resource(v1alpha1.ResourcePluralHelmApplicationVersion), version.Name, errors.New("version is immutable"))
+	}
+
 	switch request.Action {
 	case ActionCancel:
 		if version.Status.State != v1alpha1.StateSubmitted {
@@ -588,3 +598,13 @@ func (c *applicationOperator) getAppVersionsByAppId(appId string) (ret []*v1alph
 
 	return
 }
+
+// get app version from repo and helm application
+func (c *applicationOperator) getAppVersion(id string) (ret *v1alpha1.HelmApplicationVersion, err error) {
+	if ver, exists, _ := c.cachedRepos.GetAppVersion(id); exists {
+		return ver, nil
+	}
+
+	ret, err = c.versionLister.Get(id)
+	return
+}

pkg/models/openpitrix/interface.go

@@ -66,10 +66,9 @@ func NewOpenpitrixOperator(ksInformers ks_informers.InformerFactory, ksClient ve
 				cachedReposData.AddRepo(r)
 			},
 			UpdateFunc: func(oldObj, newObj interface{}) {
-				oldR := oldObj.(*v1alpha1.HelmRepo)
-				cachedReposData.DeleteRepo(oldR)
-				r := newObj.(*v1alpha1.HelmRepo)
-				cachedReposData.AddRepo(r)
+				oldRepo := oldObj.(*v1alpha1.HelmRepo)
+				newRepo := newObj.(*v1alpha1.HelmRepo)
+				cachedReposData.UpdateRepo(oldRepo, newRepo)
 			},
 			DeleteFunc: func(obj interface{}) {
 				r := obj.(*v1alpha1.HelmRepo)