From 66c0e0dad1475d1cc52a34af124a681f7d880ce5 Mon Sep 17 00:00:00 2001
From: junotx <junotx@126.com>
Date: Thu, 1 Apr 2021 16:50:13 +0800
Subject: [PATCH] fix consistent state for alerting rule

Signed-off-by: junotx <junotxiang@yunify.com>
---
 pkg/models/alerting/rules/utils.go | 37 +++++++++++-------------------
 1 file changed, 14 insertions(+), 23 deletions(-)

diff --git a/pkg/models/alerting/rules/utils.go b/pkg/models/alerting/rules/utils.go
index c243c4ba2..c385ef387 100644
--- a/pkg/models/alerting/rules/utils.go
+++ b/pkg/models/alerting/rules/utils.go
@@ -216,7 +216,8 @@ func GetAlertingRuleStatus(ruleNamespace string, rule *ResourceRule, epRuleGroup
 		return nil, nil
 	}
 
-	var epRules = make(map[string]*alerting.AlertingRule)
+	var epRule *alerting.AlertingRule
+out:
 	for _, group := range epRuleGroups {
 		fileShort := strings.TrimSuffix(filepath.Base(group.File), filepath.Ext(group.File))
 		if !strings.HasPrefix(fileShort, ruleNamespace+"-") {
@@ -226,34 +227,24 @@ func GetAlertingRuleStatus(ruleNamespace string, rule *ResourceRule, epRuleGroup
 			continue
 		}
 
-		for _, epRule := range group.Rules {
-			if eid, err := GenEndpointRuleId(group.Name, epRule, extLabels); err != nil {
+		if group.Name != rule.Group {
+			continue
+		}
+
+		for _, epr := range group.Rules {
+			if epr.Name != rule.Alert { // first check name to speed up the hit
+				continue
+			}
+			if eid, err := GenEndpointRuleId(group.Name, epr, extLabels); err != nil {
 				return nil, errors.Wrap(err, ErrGenRuleId)
 			} else {
-				if rule.Rule.Alert == epRule.Name {
-					epRules[eid] = epRule
+				if rule.Id == eid {
+					epRule = epr
+					break out
 				}
 			}
 		}
 	}
-	var epRule *alerting.AlertingRule
-	if rule.Custom {
-		// guarantees the stability of the get operations.
-		var ids []string
-		for k, _ := range epRules {
-			ids = append(ids, k)
-		}
-		if l := len(ids); l > 0 {
-			if l > 1 {
-				sort.Slice(ids, func(i, j int) bool {
-					return v2alpha1.AlertingRuleIdCompare(ids[i], ids[j])
-				})
-			}
-			epRule = epRules[ids[0]]
-		}
-	} else {
-		epRule = epRules[rule.Id]
-	}
 
 	return getAlertingRuleStatus(&rule.ResourceRuleItem, epRule, rule.Custom, rule.Level), nil
 }