migrate legacy API

Signed-off-by: hongming <talonwan@yunify.com>

pkg/models/resources/v1alpha3/deployment/deployments_test.go

@@ -1,149 +1,103 @@
 package deployment
 
 import (
-	"fmt"
 	"github.com/google/go-cmp/cmp"
-	v1 "k8s.io/api/apps/v1"
-	metaV1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime"
+	appsv1 "k8s.io/api/apps/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/informers"
 	"k8s.io/client-go/kubernetes/fake"
 	"kubesphere.io/kubesphere/pkg/api"
 	"kubesphere.io/kubesphere/pkg/apiserver/query"
+	"kubesphere.io/kubesphere/pkg/models/resources/v1alpha3"
 	"testing"
-	"time"
 )
 
-func newDeployments(total int, name, namespace, application string) []*v1.Deployment {
-	var deployments []*v1.Deployment
-
-	for i := 0; i < total; i++ {
-		deploy := &v1.Deployment{
-			TypeMeta: metaV1.TypeMeta{
-				Kind:       "Deployment",
-				APIVersion: "v1",
-			},
-			ObjectMeta: metaV1.ObjectMeta{
-				Name:      fmt.Sprintf("%s-%d", name, i),
-				Namespace: namespace,
-				Labels: map[string]string{
-					"seq": fmt.Sprintf("seq-%d", i),
-				},
-				Annotations:       map[string]string{},
-				CreationTimestamp: metaV1.Time{Time: time.Now().Add(time.Duration(i*5) * time.Second)},
-			},
-			Status: v1.DeploymentStatus{
-				ReadyReplicas:     int32(i + 1),
-				Replicas:          int32(i + 1),
-				AvailableReplicas: int32(i + 1),
-				Conditions: []v1.DeploymentCondition{
-					{
-						Type:           v1.DeploymentAvailable,
-						LastUpdateTime: metaV1.Time{Time: time.Now().Add(time.Duration(i*5) * time.Second)},
-					},
-				},
-			},
-		}
-
-		deployments = append(deployments, deploy)
-	}
-
-	return deployments
-}
-
-func deploymentsToRuntimeObjects(deployments ...*v1.Deployment) []runtime.Object {
-	var objs []runtime.Object
-	for _, deploy := range deployments {
-		objs = append(objs, deploy)
-	}
-
-	return objs
-}
-
 func TestListDeployments(t *testing.T) {
 	tests := []struct {
 		description string
 		namespace   string
-		deployments []*v1.Deployment
 		query       *query.Query
-		expected    api.ListResult
+		expected    *api.ListResult
 		expectedErr error
 	}{
 		{
 			"test name filter",
 			"bar",
-			[]*v1.Deployment{
-				{
-					ObjectMeta: metaV1.ObjectMeta{
-						Name:      "foo-1",
-						Namespace: "bar",
-					},
-				},
-				{
-					ObjectMeta: metaV1.ObjectMeta{
-						Name:      "foo-2",
-						Namespace: "bar",
-					},
-				},
-				{
-					ObjectMeta: metaV1.ObjectMeta{
-						Name:      "bar-1",
-						Namespace: "bar",
-					},
-				},
-			},
 			&query.Query{
 				Pagination: &query.Pagination{
 					Limit:  1,
-					Offset: 1,
+					Offset: 0,
 				},
 				SortBy:    query.FieldName,
 				Ascending: false,
 				Filters: []query.Filter{
 					{
 						Field: query.FieldName,
-						Value: query.Value("foo"),
+						Value: query.Value("foo2"),
 					},
 				},
 			},
-			api.ListResult{
+			&api.ListResult{
 				Items: []interface{}{
-					&v1.Deployment{
-						ObjectMeta: metaV1.ObjectMeta{
-							Name:      "foo-2",
-							Namespace: "bar",
-						},
-					},
+					foo2,
 				},
-				TotalItems: 2,
+				TotalItems: 1,
 			},
 			nil,
 		},
 	}
 
+	getter := prepare()
+
 	for _, test := range tests {
 		t.Run(test.description, func(t *testing.T) {
-			objs := deploymentsToRuntimeObjects(test.deployments...)
-			client := fake.NewSimpleClientset(objs...)
-
-			informer := informers.NewSharedInformerFactory(client, 0)
-
-			for _, deployment := range test.deployments {
-				informer.Apps().V1().Deployments().Informer().GetIndexer().Add(deployment)
-			}
-
-			getter := New(informer)
 
 			got, err := getter.List(test.namespace, test.query)
+
 			if test.expectedErr != nil && err != test.expectedErr {
 				t.Errorf("expected error, got nothing")
 			} else if err != nil {
 				t.Fatal(err)
 			}
 
-			if diff := cmp.Diff(got.Items, test.expected.Items); diff != "" {
+			if diff := cmp.Diff(got, test.expected); diff != "" {
 				t.Errorf("%T differ (-got, +want): %s", test.expected, diff)
 			}
 		})
 	}
 }
+
+var (
+	foo1 = &appsv1.Deployment{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "foo1",
+			Namespace: "bar",
+		},
+	}
+
+	foo2 = &appsv1.Deployment{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "foo2",
+			Namespace: "bar",
+		},
+	}
+	bar1 = &appsv1.Deployment{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "bar1",
+			Namespace: "bar",
+		},
+	}
+
+	deployments = []interface{}{foo1, foo2, bar1}
+)
+
+func prepare() v1alpha3.Interface {
+	client := fake.NewSimpleClientset()
+	informer := informers.NewSharedInformerFactory(client, 0)
+
+	for _, deployment := range deployments {
+		informer.Apps().V1().Deployments().Informer().GetIndexer().Add(deployment)
+	}
+
+	return New(informer)
+}