Fix the incorrect approvable check of Pipeline input

Signed-off-by: rick <rick@jenkins-zh.cn>
This commit is contained in:
rick
2021-01-20 10:32:50 +08:00
parent 1f4d5cb686
commit 530c6911a5
8 changed files with 114 additions and 58 deletions

View File

@@ -1122,14 +1122,10 @@ func (i *Input) GetSubmitters() (submitters []string) {
func (i *Input) Approvable(identify string) (ok bool) {
submitters := i.GetSubmitters()
// it means anyone can approve this if there's no specific one
if len(submitters) == 0 {
ok = true
} else {
for _, submitter := range submitters {
if submitter == identify {
ok = true
}
for _, submitter := range submitters {
if submitter == identify {
ok = true
break
}
}
return