From 4d19c4dbb400a4a6c4372777fcaef3f3e3d2a90c Mon Sep 17 00:00:00 2001 From: rick Date: Mon, 7 Dec 2020 11:09:37 +0800 Subject: [PATCH] Provide a specific log level instead of using log.error unifi variable declare style Signed-off-by: rick --- pkg/kapis/devops/v1alpha2/devops.go | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/pkg/kapis/devops/v1alpha2/devops.go b/pkg/kapis/devops/v1alpha2/devops.go index 76022084e..f9d8ca52c 100644 --- a/pkg/kapis/devops/v1alpha2/devops.go +++ b/pkg/kapis/devops/v1alpha2/devops.go @@ -236,7 +236,7 @@ func (h *ProjectPipelineHandler) createdBy(projectName string, pipelineName stri return creator == currentUserName } } else { - log.Error(fmt.Sprintf("cannot get pipeline %s/%s, error %#v", projectName, pipelineName, err)) + log.V(4).Infof("cannot get pipeline %s/%s, error %#v", projectName, pipelineName, err) } return false } @@ -298,7 +298,7 @@ func (h *ProjectPipelineHandler) hasSubmitPermission(req *restful.Request) (hasP break } } else { - log.Errorf("cannot get nodes detail, error: %v", err) + log.V(4).Infof("cannot get nodes detail, error: %v", err) err = errors.New("cannot get the submitters of current pipeline run") return } @@ -312,11 +312,9 @@ func (h *ProjectPipelineHandler) SubmitInputStep(req *restful.Request, resp *res nodeId := req.PathParameter("node") stepId := req.PathParameter("step") - var ( - response []byte - err error - ok bool - ) + var response []byte + var err error + var ok bool if ok, err = h.hasSubmitPermission(req); !ok || err != nil { msg := map[string]string{ @@ -520,11 +518,9 @@ func (h *ProjectPipelineHandler) SubmitBranchInputStep(req *restful.Request, res nodeId := req.PathParameter("node") stepId := req.PathParameter("step") - var ( - response []byte - err error - ok bool - ) + var response []byte + var err error + var ok bool if ok, err = h.hasSubmitPermission(req); !ok || err != nil { msg := map[string]string{