From 492b4ae8c2388f458cacfb8d467ecb1710b8522f Mon Sep 17 00:00:00 2001 From: Zhengyi Lai Date: Wed, 6 Jan 2021 15:02:20 +0800 Subject: [PATCH] Add network.topology into conf.ToMap() Signed-off-by: Zhengyi Lai --- pkg/apiserver/config/config.go | 9 ++++++++- pkg/simple/client/network/options.go | 10 +++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/pkg/apiserver/config/config.go b/pkg/apiserver/config/config.go index 7255a3c8b..fc1aafe4c 100644 --- a/pkg/apiserver/config/config.go +++ b/pkg/apiserver/config/config.go @@ -170,6 +170,7 @@ func (conf *Config) ToMap() map[string]bool { if name == "network" { ippoolName := "network.ippool" nsnpName := "network" + networkTopologyName := "network.topology" if conf.NetworkOptions == nil { result[nsnpName] = false result[ippoolName] = false @@ -185,6 +186,12 @@ func (conf *Config) ToMap() map[string]bool { } else { result[ippoolName] = true } + + if conf.NetworkOptions.WeaveScopeHost == "" { + result[networkTopologyName] = false + } else { + result[networkTopologyName] = true + } } continue } @@ -226,7 +233,7 @@ func (conf *Config) stripEmptyOptions() { conf.OpenPitrixOptions = nil } - if conf.NetworkOptions != nil && conf.NetworkOptions.EnableNetworkPolicy == false { + if conf.NetworkOptions != nil && conf.NetworkOptions.IsEmpty() { conf.NetworkOptions = nil } diff --git a/pkg/simple/client/network/options.go b/pkg/simple/client/network/options.go index 65a7e2d7e..d71f127e9 100644 --- a/pkg/simple/client/network/options.go +++ b/pkg/simple/client/network/options.go @@ -18,6 +18,8 @@ package network import ( "github.com/spf13/pflag" + + networkv1alpha1 "kubesphere.io/kubesphere/pkg/apis/network/v1alpha1" ) type NSNPOptions struct { @@ -35,7 +37,7 @@ type Options struct { func NewNetworkOptions() *Options { return &Options{ EnableNetworkPolicy: false, - IPPoolType: "none", + IPPoolType: networkv1alpha1.IPPoolTypeNone, NSNPOptions: NSNPOptions{ AllowedIngressNamespaces: []string{}, }, @@ -43,6 +45,12 @@ func NewNetworkOptions() *Options { } } +func (s *Options) IsEmpty() bool { + return s.EnableNetworkPolicy == false && + s.WeaveScopeHost == "" && + s.IPPoolType == networkv1alpha1.IPPoolTypeNone +} + func (s *Options) Validate() []error { var errors []error return errors