From 35cf45a0b7a8e6b157aacfe4a3f266af869a3e64 Mon Sep 17 00:00:00 2001 From: johnniang Date: Wed, 23 Feb 2022 17:04:11 +0800 Subject: [PATCH] Fix verification error and failing tests Signed-off-by: johnniang --- pkg/kapis/devops/register.go | 1 + pkg/kapis/devops/register_test.go | 8 ++++++-- tools/cmd/doc-gen/main.go | 3 ++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/pkg/kapis/devops/register.go b/pkg/kapis/devops/register.go index c9ed10470..95ad1fe05 100644 --- a/pkg/kapis/devops/register.go +++ b/pkg/kapis/devops/register.go @@ -18,6 +18,7 @@ package devops import ( "github.com/emicklei/go-restful" + "kubesphere.io/kubesphere/pkg/kapis/generic" ) diff --git a/pkg/kapis/devops/register_test.go b/pkg/kapis/devops/register_test.go index 94059db58..253864fbe 100644 --- a/pkg/kapis/devops/register_test.go +++ b/pkg/kapis/devops/register_test.go @@ -17,11 +17,12 @@ limitations under the License. package devops import ( - "github.com/emicklei/go-restful" - "github.com/stretchr/testify/assert" "net/http" "net/http/httptest" "testing" + + "github.com/emicklei/go-restful" + "github.com/stretchr/testify/assert" ) func TestAddToContainer(t *testing.T) { @@ -41,6 +42,7 @@ func TestAddToContainer(t *testing.T) { args: args{ target: "/kapis/devops.kubesphere.io/v1alpha1/resources", mockAPIPattern: "/v1alpha1/resources", + mockResponse: fakeResponse, }, wantResponse: fakeResponse, }, { @@ -48,6 +50,7 @@ func TestAddToContainer(t *testing.T) { args: args{ target: "/kapis/devops.kubesphere.io/v1alpha2/resources", mockAPIPattern: "/v1alpha2/resources", + mockResponse: fakeResponse, }, wantResponse: fakeResponse, }, { @@ -55,6 +58,7 @@ func TestAddToContainer(t *testing.T) { args: args{ target: "/kapis/devops.kubesphere.io/v1alpha3/resources", mockAPIPattern: "/v1alpha3/resources", + mockResponse: fakeResponse, }, wantResponse: fakeResponse, }, { diff --git a/tools/cmd/doc-gen/main.go b/tools/cmd/doc-gen/main.go index f87e8af27..bbdb37362 100644 --- a/tools/cmd/doc-gen/main.go +++ b/tools/cmd/doc-gen/main.go @@ -22,9 +22,10 @@ import ( "flag" "fmt" "io/ioutil" - kapisdevops "kubesphere.io/kubesphere/pkg/kapis/devops" "log" + kapisdevops "kubesphere.io/kubesphere/pkg/kapis/devops" + "kubesphere.io/kubesphere/pkg/client/clientset/versioned/fake" "kubesphere.io/kubesphere/pkg/version"