From 299c0d46db911e4dacff6d97e565794df7d6792b Mon Sep 17 00:00:00 2001 From: inksnw Date: Thu, 31 Oct 2024 11:41:08 +0800 Subject: [PATCH] Allow version comparison errors (#6257) --- pkg/simple/client/application/helper.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/simple/client/application/helper.go b/pkg/simple/client/application/helper.go index dcc0d9df1..c41ca3b7a 100644 --- a/pkg/simple/client/application/helper.go +++ b/pkg/simple/client/application/helper.go @@ -298,7 +298,12 @@ func UpdateLatestAppVersion(ctx context.Context, client runtimeclient.Client, ap klog.Warningf("failed to parse version: %s, use first version %s", v.Spec.VersionName, latestAppVersion) continue } - if parsedVersion.GT(semver.MustParse(strings.TrimPrefix(latestAppVersion, "v"))) { + oldLatestAppVersion, err := semver.Parse(strings.TrimPrefix(latestAppVersion, "v")) + if err != nil { + klog.Warningf("failed to parse oldLatestAppVersion: %s", latestAppVersion) + continue + } + if parsedVersion.GT(oldLatestAppVersion) { latestAppVersion = v.Spec.VersionName } }